Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817193 Peter Lemenkov <lemenkov@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lemenkov@xxxxxxxxx --- Comment #1 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2012-04-28 05:09:34 EDT --- (In reply to comment #0) > rpmlint: > $ rpmlint libccd.spec ../RPMS/x86_64/libccd-* > libccd.x86_64: W: shared-lib-calls-exit /usr/lib64/libccd.so.1.2 > exit@GLIBC_2.2.5 > libccd-static.x86_64: W: no-documentation > 4 packages and 1 specfiles checked; 0 errors, 2 warnings. > > I'm looking into the exit() warning, but I don't know if it's a showstopper. >From my pov - this is a defect in the library's architecture but not a review blocker. For those who are not aware of this issue - it is considered as a good practice to return descriptive error values from the library in case of errors and not to die immediately (this should be up to the underlying application(s) how to behave in this sorrow situation). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review