Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=801077 --- Comment #6 from Liang Suilong <liangsuilong@xxxxxxxxx> 2012-04-27 13:15:02 EDT --- The spec file and SRPM have been updated. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4029319 SRPM:http://liangsuilong.fedorapeople.org/fcitx/fcitx-libpinyin-0.1.1-1.fc16.src.rpm SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-libpinyin.spec (In reply to comment #5) > 1) Are you going to push this for EPEL? If not then > a) %clean section (see > http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean) > b) removal of buildroot in %install (remove line rm -rf $RPM_BUILD_ROOT) > c) remove line %defattr(-,root,root,-) i hope the package will push to EPEL. > 2) Missing Requires: fcitx Fcitx has been added. > 3) rpmlint on rpms gave > fcitx-libpinyin.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: > line 5) > fcitx-libpinyin.src: W: invalid-url Source0: > http://fcitx.googlecode.com/files/fcitx-libpinyin-0.1.1_dict.tar.xz HTTP Error > 404: Not Found > fcitx-libpinyin.x86_64: E: incorrect-fsf-address > /usr/share/doc/fcitx-libpinyin-0.1.1/COPYING > 2 packages and 0 specfiles checked; 1 errors, 2 warnings. > > ==> as shown above comment1, you can fix mixed-use-of-spaces-and-tabs and for > incorrect-fsf-address, you can ask upstream to change the address. invalid-url > warning can be ignored. Invalid-url warning is ignored. I can click the url and download the source tarball. And another issues are fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review