Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: ftp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225774 ruben@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|ruben@xxxxxxxxxxxxxxxx |mmaslano@xxxxxxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From ruben@xxxxxxxxxxxxxxxx 2007-02-03 11:27 EST ------- * RPM name is OK * Source netkit-ftp-0.17.tar.bz2 is the same as upstream * Builds fine in mock * File list looks OK rpmlint is not silent: Source RPM: W: ftp summary-ended-with-dot The standard UNIX FTP (File Transfer Protocol) client. W: ftp no-url-tag W: ftp hardcoded-path-in-buildroot-tag /var/tmp/%{name}-root Needs work: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * BuildRequires: gcc should not be included (wiki: PackagingGuidelines#Exceptions) * BuildRequires: perl should not be included (wiki: PackagingGuidelines#Exceptions) * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines) * Your debuginfo package is empty. This is because binaries are installed with install -s * You're missing the URL tag -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review