Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=815814 --- Comment #13 from Vít Ondruch <vondruch@xxxxxxxxxx> 2012-04-27 04:32:13 EDT --- (In reply to comment #7) Thank you. Also thank you for asking the upstream. Regarding this, I have another two nits: 1) The summary in spec file should be the same as the bug summary. 2) The description should be wrapped at 80 lines [1] And I have other comments to the spec file: * gem_dir and gem_instdir are not needed - These macros are provided by rubygems-devel package, so you don't have to declare them for Fedora. Please remove their re-definitions. * Use %{gem_libdir} instead of %{gem_instdir}/lib - It simplifies the spec file a bit. * BuildRequires: ruby(rubygems) is not required - Since rubygems-devel requires the rubygems package anyway, you don't have to BuildRequire it explicitly. * test suit - It would be nice if you could execute test suite of that gem. You can find some hints about test suite in guidelines [2] * Move README.md into the main package - Since this file mentions license of the package, it should be moved into the main package * Keep Gemfile* in -doc subpackage - There is no need to drop the Gemfiles IMO. You can keep them in the -doc subpackage. BTW "gem2rpm -t fedora-17-rawhide paranoia-1.1.0.gem" would help you to generate the stub of the package with correct macros. [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description [2] https://fedoraproject.org/wiki/Packaging:Ruby#Running_test_suites -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review