[Bug 815624] Review Request: xedit - Simple text editor for X

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=815624

--- Comment #3 from pcpa <paulo.cesar.pereira.de.andrade@xxxxxxxxx> 2012-04-26 18:22:26 EDT ---
(In reply to comment #2)
> Quick comments:
> 
> - add disttag
> - one req. on each line please
> - don't use %make_install
> - defattr is almost correct :-)

  Thanks for the comments. I noticed there was a missing
buildrequires to desktop-file-utils, and corrected the
issues in your comment. Earlier I only knew rpmlint was
happy with it :-)

> Please create FAS account and do a koji scratch build.

  I had already created one, but did first scratch build
now.

  Not sure if should add a link to koji task to bugzilla as it
should be valid for only a short amount of time, but here it is
https://koji.fedoraproject.org/koji/taskinfo?taskID=4027234

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]