[Bug 816124] Review Request: libdb4 - Oracle (Berkeley) DB package 4.x.x series

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=816124

--- Comment #2 from Jon Ciesla <limburgher@xxxxxxxxx> 2012-04-26 11:43:50 EDT ---
rpmlint output trimmed and grouped for clarity.

! rpmlint checks return: 

libdb4-cxx-devel.x86_64: W: no-dependency-on
libdb4-cxx/libdb4-cxx-libs/liblibdb4-cxx
libdb4-java-devel.x86_64: W: no-dependency-on
libdb4-java/libdb4-java-libs/liblibdb4-java
libdb4-tcl-devel.x86_64: W: no-dependency-on
libdb4-tcl/libdb4-tcl-libs/liblibdb4-tcl

Fix?

libdb4-cxx-devel.x86_64: W: no-documentation
libdb4-devel.x86_64: W: no-documentation
libdb4-devel-static.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

Fix if possible.

libdb4-devel-doc.x86_64: E: devel-dependency libdb4-devel
Your package has a dependency on a devel package but it's not a devel package
itself.

Ignore.

libdb4-devel-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb4-devel-doc-4.8.30/csharp/scripts/Dropdown.js
libdb4-devel-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb4-devel-doc-4.8.30/csharp/FillNode.aspx
libdb4-devel-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb4-devel-doc-4.8.30/csharp/styles/Presentation.css
libdb4-devel-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb4-devel-doc-4.8.30/csharp/SearchHelp.aspx
libdb4-devel-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb4-devel-doc-4.8.30/csharp/scripts/EventUtilities.js
libdb4-devel-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb4-devel-doc-4.8.30/csharp/scripts/script_feedBack.js
libdb4-devel-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb4-devel-doc-4.8.30/csharp/Web.Config
libdb4-devel-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb4-devel-doc-4.8.30/csharp/scripts/CheckboxMenu.js
libdb4-devel-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb4-devel-doc-4.8.30/csharp/WebTOC.xml
libdb4-devel-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb4-devel-doc-4.8.30/csharp/Index.aspx
libdb4-devel-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb4-devel-doc-4.8.30/csharp/styles/highlight.css
libdb4-devel-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb4-devel-doc-4.8.30/csharp/LoadIndexKeywords.aspx
libdb4-devel-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb4-devel-doc-4.8.30/csharp/WebKI.xml
libdb4-devel-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb4-devel-doc-4.8.30/csharp/scripts/highlight.js
libdb4-devel-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb4-devel-doc-4.8.30/csharp/scripts/SplitScreen.js
libdb4-devel-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb4-devel-doc-4.8.30/csharp/scripts/script_manifold.js
libdb4-devel-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb4-devel-doc-4.8.30/csharp/TOC.css
libdb4-devel-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb4-devel-doc-4.8.30/csharp/scripts/CommonUtilities.js
libdb4-devel-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb4-devel-doc-4.8.30/csharp/styles/Whidbey/presentation.css
libdb4-devel-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb4-devel-doc-4.8.30/csharp/TOC.js
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

Fix.

libdb4-devel-static.x86_64: W: spelling-error %description -l en_US statical ->
statically, statistical, statistic
The value of this tag appears to be misspelled. Please double-check.

Change statical to static.

libdb4-tcl-devel.x86_64: W: no-documentation
libdb4-utils.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

Fix if feasible.

libdb4-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db4_recover
['/usr/lib64']
libdb4-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db4_verify
['/usr/lib64']
libdb4-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db4_stat
['/usr/lib64']
libdb4-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db4_checkpoint
['/usr/lib64']
libdb4-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db4_load
['/usr/lib64']
libdb4-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db4_hotbackup
['/usr/lib64']
libdb4-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db4_archive
['/usr/lib64']
libdb4-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db4_dump
['/usr/lib64']
libdb4-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db4_sql
['/usr/lib64']
libdb4-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db4_deadlock
['/usr/lib64']
libdb4-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db4_printlog
['/usr/lib64']
libdb4-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db4_upgrade
['/usr/lib64']
The binary or shared library defines `RPATH'. Usually this is a bad thing
because it hardcodes the path to search libraries and so makes it difficult to
move libraries around.  Most likely you will find a Makefile with a line like:
gcc test.o -o test -Wl,--rpath.  Also, sometimes configure scripts provide a
--disable-rpath flag to avoid this.

Fix.

libdb4-utils.x86_64: W: no-manual-page-for-binary db4_sql
libdb4-utils.x86_64: W: no-manual-page-for-binary db4_archive
libdb4-utils.x86_64: W: no-manual-page-for-binary db4_printlog
libdb4-utils.x86_64: W: no-manual-page-for-binary db4_recover
libdb4-utils.x86_64: W: no-manual-page-for-binary db4_dump
libdb4-utils.x86_64: W: no-manual-page-for-binary db4_dump185
libdb4-utils.x86_64: W: no-manual-page-for-binary db4_hotbackup
libdb4-utils.x86_64: W: no-manual-page-for-binary db4_checkpoint
libdb4-utils.x86_64: W: no-manual-page-for-binary db4_load
libdb4-utils.x86_64: W: no-manual-page-for-binary db4_upgrade
libdb4-utils.x86_64: W: no-manual-page-for-binary db4_verify
libdb4-utils.x86_64: W: no-manual-page-for-binary db4_deadlock
libdb4-utils.x86_64: W: no-manual-page-for-binary db4_stat

Fix if feasible.

- package meets naming guidelines
- package meets packaging guidelines
- license ( Sleepycat and BSD ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 

Pretty good, and I'm not sure what of the above is fixable given that it's
older code, but what can needs to be.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]