Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=801062 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2012-04-26 10:34:24 EDT --- Review:- + koji scratch build for f17 -> http://koji.fedoraproject.org/koji/taskinfo?taskID=4024880 + rpmlint on rpms gave fcitx-keyboard.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 5) fcitx-keyboard.src: W: invalid-url Source0: http://fcitx.googlecode.com/files/fcitx-keyboard-0.1.0.tar.bz2 HTTP Error 404: Not Found fcitx-keyboard.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 3 warnings. + Source verified with upstream as (sha1sum) 98a8f1340c2fe0c835f2d09d95cb18df825d75b4 fcitx-keyboard-0.1.0.tar.bz2 98a8f1340c2fe0c835f2d09d95cb18df825d75b4 ../SOURCES/fcitx-keyboard-0.1.0.tar.bz2 + Package : fcitx-keyboard-0.1.0-1.fc17.x86_64 Provides: fcitx-keyboard.so()(64bit) fcitx-xkb.so()(64bit) Requires: libX11.so.6()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3)(64bit) libenchant.so.1()(64bit) libicuuc.so.48()(64bit) libxkbfile.so.1()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) rtld(GNU_HASH) Suggestions:- 1) Fix the rpmlint messages. a) mixed-use-of-spaces-and-tabs message can be fixed using command sed -i 's|\t| |g' fcitx-keyboard.spec 2) If package is only for Fedora then no need to add a) %clean section (see http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean) b) removal of buildroot in %install (remove line rm -rf $RPM_BUILD_ROOT) c) remove line %defattr(-,root,root,-) 3) please don't use commands in macro that is change %{__mkdir} to "mkdir" 4) package should add Requires: fcitx, fcitx-data 5) Use following commands in %build %cmake .. make VERBOSE=1 %{?_smp_mflags} 6) %install should preserve timestamp using make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" 7) Add COPYING to %doc -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review