Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809116 --- Comment #3 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> 2012-04-26 06:00:01 EDT --- (In reply to comment #1) > As I wrote in bug 809114, a Requires on novacomd should be add to this package. > By the way, I would update the description to specify that the novacomd service > must be enabled. This comment can be ignored, see bug #809114 for details. You should add a comment to describe the way the sources can be retrieved, or provide a direct URL to get them (as in novacom-server). You should use %global instead of %define here: http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define Since gcc is part of the implicit BuildRequires, you don't need to add glibc-devel to the list of BR: http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 It looks like the client sources include parts of libtomcrypt (see files src/base64.*). Fortunately, they're not used by novacom. I wonder if it's worth deleting them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review