[Bug 801077] Review Requst: fcitx-libpinyin - Libpinyin Wrapper for Fcitx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=801077

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
               Flag|                            |fedora-review?

--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2012-04-26 05:18:23 EDT ---
Review:-
+ koji scratch build for f17
->http://koji.fedoraproject.org/koji/taskinfo?taskID=4023812

+ rpmlint on rpms gave
fcitx-libpinyin.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab:
line 5)
fcitx-libpinyin.src: W: invalid-url Source0:
http://fcitx.googlecode.com/files/fcitx-libpinyin-0.1.0_dict.tar.bz2 HTTP Error
404: Not Found
fcitx-libpinyin.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ Source verified with upstream as (sha1sum)
de5b67fd10357885bc0386cb887ea09e5c48a53f  fcitx-libpinyin-0.1.0_dict.tar.bz2
de5b67fd10357885bc0386cb887ea09e5c48a53f 
../SOURCES/fcitx-libpinyin-0.1.0_dict.tar.bz2

+ Package: fcitx-libpinyin-0.1.0-1.fc17.x86_64
Provides: fcitx-libpinyin.so()(64bit)
Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit)
libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libglib-2.0.so.0()(64bit)
libpinyin.so.0()(64bit) libpinyin.so.0(LIBPINYIN)(64bit)
libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH)


Suggestions:-
1) Fix the rpmlint messages. 
  a) mixed-use-of-spaces-and-tabs message can be fixed using command
     sed -i 's|\t| |g' fcitx-libpinyin.spec

2) If package is only for Fedora then no need to add
  a) %clean section (see
http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean)
  b) removal of buildroot in %install (remove line rm -rf $RPM_BUILD_ROOT)
  c) remove line %defattr(-,root,root,-)

3) please don't use commands in macro that is change %{__mkdir} to "mkdir"

4) package should add Requires:fcitx

5) Use following commands in %build
%cmake ..
make VERBOSE=1 %{?_smp_mflags}

6) You need to use
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache as you are
installing icon files.

7) %install should preserve timestamp using 
   make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

8) Package does not own some of directories so change %files to

%{_datadir}/fcitx/addon/
%{_datadir}/fcitx/configdesc/
%{_datadir}/fcitx/inputmethod/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]