Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800731 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2012-04-26 03:09:56 EDT --- Review:- + koji scratch build for f17 ->http://koji.fedoraproject.org/koji/taskinfo?taskID=4023810 + rpmlint on rpms gave fcitx-table-extra.src: W: spelling-error %description -l en_US Boshiamy -> Bosomy fcitx-table-extra.src: W: strange-permission fcitx-table-extra.spec 0777L fcitx-table-extra.src:41: W: macro-in-comment %{_datadir} fcitx-table-extra.src:42: W: macro-in-comment %{_datadir} fcitx-table-extra.src:42: W: macro-in-comment %{_datadir} fcitx-table-extra.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 5) fcitx-table-extra.src: W: invalid-url Source0: http://fcitx.googlecode.com/files/fcitx-table-extra-0.1.0.tar.bz2 HTTP Error 404: Not Found fcitx-table-extra.noarch: W: spelling-error %description -l en_US Boshiamy -> Bosomy fcitx-table-extra.noarch: E: zero-length /usr/share/doc/fcitx-table-extra-0.1.0/ChangeLog 2 packages and 0 specfiles checked; 1 errors, 8 warnings. + Source verified with upstream as (sha1sum) 71a37f869bbe8a6876f7cabd8294a7346849aee9 fcitx-table-extra-0.1.0.tar.bz2 71a37f869bbe8a6876f7cabd8294a7346849aee9 ../SOURCES/fcitx-table-extra-0.1.0.tar.bz2 suggestions: 1) Fix the rpmlint messages. a) macro when added in comment should use %% instead of % b) mixed-use-of-spaces-and-tabs message can be fixed using command sed -i 's|\t| |g' fcitx-table-extra.spec c) zero-length error can be fixed by removing it from spec 2) If package is only for Fedora then no need to add a) %clean section (see http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean) b) removal of buildroot in %install (remove line rm -rf $RPM_BUILD_ROOT) c) remove line %defattr(-,root,root,-) 3) please don't use commands in macro that is change %{__mkdir} to "mkdir" 4) package don't need to BuildRequires:fcitx but Requires:fcitx 5) make each line of description of 80 characters. 6) Ask the upstream to add license file in tarball. 7) You need to use http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache as you are installing icon files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review