Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789240 --- Comment #3 from Juan Orti Alcaine <j.orti.alcaine@xxxxxxxxx> 2012-04-25 06:48:16 EDT --- The spec file is not updated, I take the one in the srpm. - The Source0 url isn't working for me, it downloads a html page, please change this line with: Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz - The man page has a unknown macro in the line 148, I have tried to delete that line and seems ok, I attach the patch I've used. - Remember to submit the patches upstream and add a comment in the spec file with the bug report. - In the icon scriptlets, it's missing the "|| :" at the end of some commands in %post and %postun. Add them to avoid possible errors, see: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - In the %files section I prefer to have freqtweak substituted by %{name} -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review