Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=814804 --- Comment #2 from Kalev Lember <kalevlember@xxxxxxxxx> 2012-04-24 21:38:35 EDT --- It doesn't seem to build in koji. Scratch builds for both F17 and rawhide fail with a self test error: > The following tests FAILED: > 1 - ocio_core_tests (Failed) http://koji.fedoraproject.org/koji/taskinfo?taskID=4020499 > Patch0: OpenColorIO-1.0.7-pylib_no_soname.patch > Patch1: OpenColorIO-1.0.7-docfix.patch Have you sent these changes upstream? The first patch rips out the code that sets the SOVERSION for the shared object; why is such a change needed? Would be great to have a comment explaining this in the spec file. > %files > [...] > %{_datadir}/ocio/setup_ocio.sh Should own the directory as well, to avoid leaving behind unowned directories when uninstalling the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review