[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737401

--- Comment #17 from Jerry James <loganjerry@xxxxxxxxx> 2012-04-24 15:17:55 EDT ---
Great, you've done a lot of work on this.  Let me know when the Proj 4.8 issue
is resolved and I'll give it a try.  In the meantime, here are a couple of
comments from scanning the spec file.

First, the dos2unix BR is usually unnecessary.  Most of the time, something
like this will do the same job:

sed -i 's/\r//' AUTHORS

Second, you can't use the Provides filtering method you are using.  See
https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Usage
for the reason why.  However, you can use RPM 4.9 filtering; see
https://fedorahosted.org/fpc/ticket/76.  In your case, you can replace the
filter statements with this (just before %prep):

%global __provides_exclude_from ^%{python_sitearch}/.*\\.so$

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]