Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kpowersave - kde power control applet https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226892 ------- Additional Comments From gauret@xxxxxxx 2007-02-03 05:27 EST ------- Needs work: * Please remove /usr/lib/libkdeinit_kpowersave.la, it should be useless (http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries). /usr/lib/kde3/kpowersave.la is probably needed however, please keep it. * As kpowersave ships icons in the hicolor directory, it should have "Requires: hicolor-icon-theme" https://www.redhat.com/archives/fedora-extras-list/2006-September/msg00282.html Everything else looks OK, good job. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review