Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806446 --- Comment #8 from Germán Racca <gracca@xxxxxxxxx> 2012-04-23 14:53:29 EDT --- Hi Gregor, Here follow the changes I made to the package: - Dropped gcc-c++ from BR - Removed bundled qtsingleapplication - Added patch to use system qtsingleapplication - Added qtsingleapplication-devel as BR - Added desktop-file-utils as BR - Removed wrong category form desktop file - Dropped minitunes-1.0-gcc47.patch - Added icon scriptlets - Dropped INSTALL from %%doc - Added patch to fix include in 2 cpp files I also had to create a very simple patch because of the includes, you can take a look at it, because it couldn't compile after removing the bundled library. The only thing I didn't do was checking the translations, but I'm creating a VM right now to do that. What I'm supposed to do? Do I have to change the language of the whole Fedora and restart Gnome every time, and see if Musique is in that language? Because I still don't understand what is wrong with those locale files. Spec: http://skytux.fedorapeople.org/packages/musique.spec SRPM: http://skytux.fedorapeople.org/packages/musique-1.1-6.fc16.src.rpm Rawhide --> http://koji.fedoraproject.org/koji/taskinfo?taskID=4015894 F - 17 --> http://koji.fedoraproject.org/koji/taskinfo?taskID=4015941 F - 16 --> http://koji.fedoraproject.org/koji/taskinfo?taskID=4015982 All the best, Germán. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review