Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811601 Richard W.M. Jones <rjones@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Richard W.M. Jones <rjones@xxxxxxxxxx> 2012-04-23 12:00:06 EDT --- (In reply to comment #3) > General comment: I think you should add a comment about how Fedora > itself is the upstream for this package. Also I think man pages would > improve this package. Both of these issues are fixed. > - rpmlint output > > Some notable issues raised by rpmlint: > > openstack-utils.src: W: strange-permission openstack-config 0775L > openstack-utils.src: W: strange-permission openstack-status 0775L > openstack-utils.src: W: strange-permission openstack-demo-install 0775L > openstack-utils.src: W: strange-permission openstack-db 0775L Fixed by using `install -m' in spec file. > openstack-utils.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/openstack-utils-2012.1/LICENSE Fixed upstream. > openstack-utils.noarch: W: no-manual-page-for-binary openstack-demo-install > openstack-utils.noarch: W: no-manual-page-for-binary openstack-config > openstack-utils.noarch: W: no-manual-page-for-binary openstack-status > openstack-utils.noarch: W: no-manual-page-for-binary openstack-db Fixed by adding man pages for all utilities. > I'm not sure what this one means: > > openstack-utils.noarch: W: devel-file-in-non-devel-package > /usr/bin/openstack-config We agree this is not important. ========================= This package is APPROVED by rjones ========================= -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review