Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812751 --- Comment #5 from Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> 2012-04-23 07:31:07 EDT --- The packaging guidelines say: "If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc." There is no separate license text file in the git checkout, only license statements in the source files. The guideline above says that the packager should not create one if it is missing. It was well spotted to find that one of the source file had a different license than all the others. I have changed the specfile accordingly. I have also changed to use macros in more places than before, as requested. http://www.grid.tsl.uu.se/review/jglobus-2.0.4-2.fc17.src.rpm http://www.grid.tsl.uu.se/review/jglobus.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review