Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=814458 Rich Mattes <richmattes@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |richmattes@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |richmattes@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Rich Mattes <richmattes@xxxxxxxxx> 2012-04-22 17:45:52 EDT --- This package looks pretty simple, I'll go ahead and review it. + = PASS, - = FAIL, N = Not Applicable. [+] rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review $ rpmlint ../SRPMS/fparser-4.4.3-1.fc15.src.rpm ../RPMS/x86_64/fparser* 4 packages and 0 specfiles checked; 0 errors, 0 warnings. [+] The package must be named according to the Package Naming Guidelines . [+] The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [+] The package must meet the Packaging Guidelines. The MUST items are covered, but the guidelines indicate that patches SHOULD include a comment with each patch file. The patch included includes a full CMake-based build system. Have you been in contact with upstream about it? [+] The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [+] The License field in the package spec file must match the actual license. [N] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] The spec file must be written in American English. [+] The spec file for the package MUST be legible. [+] The sources used to build the package must match the upstream source, as provided in the spec URL. $ md5sum fparser4.4.3.zip ../SOURCES/fparser4.4.3.zip 035ee59ed53d4ec723186625293fbb8b fparser4.4.3.zip 035ee59ed53d4ec723186625293fbb8b ../SOURCES/fparser4.4.3.zip [+] The package MUST successfully compile and build into binary rpms on at least one primary architecture. [N] If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. [+] All build dependencies must be listed in BuildRequires. [N] The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. [+] Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [+] Packages must NOT bundle copies of system libraries. [N] If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. [+] A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [+] A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations) [+] Permissions on files must be set properly. Executables should be set with executable permissions, for example. [+] Each package must consistently use macros. [+] The package must contain code, or permissable content. [N] Large documentation files must go in a -doc subpackage [+] If a package includes something as %doc, it must not affect the runtime of the application. [+] Static libraries must be in a -static package. [+] Development files must be in a -devel package. [-] In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} I think this is a newer requirement, but it is a simple fix. [+] Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [N] Packages containing GUI applications must include a %{name}.desktop file. [+] Packages must not own files or directories already owned by other packages. [+] All filenames in rpm packages must be valid UTF-8. So action items are * Include the %{?_isa} macro in the -devel package's Requires field * Include a comment about the CMake patch. It would be much easier on us if upstream takes the cmake patch and/or adds their own build scripts to the release tarballs, I'd like to if they're receptive to this idea or if the cmake patch will have to be a fedora-only patch. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review