[Bug 814924] Review Request: jalv - a simple LV2 host

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=814924

Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

--- Comment #1 from Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> 2012-04-22 15:36:19 EDT ---
Fedora Review jalv 2012-04-22

$ rpmlint jalv*.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ Package named according to guidelines
+ Specfile named after package
+ Package license (MIT) is Fedora approved
+ Package license mateches license statements in sources
+ License file (COPYING) included as %doc
+ Specfile is written in readable American English
+ Package source matches upstream:

$ md5sum jalv-1.0.0.tar.bz2 jalv-srpm/jalv-1.0.0.tar.bz2 
f20f81dbb437f4e4ea10e00694f6cc4d  jalv-1.0.0.tar.bz2
f20f81dbb437f4e4ea10e00694f6cc4d  srpm/jalv-1.0.0.tar.bz2

- Package fails to compile due to several missing build requires:
    BuildRequires:  python
    BuildRequires:  suil-devel >= 0.6.0
    BuildRequires:  jack-audio-connection-kit-devel

[ Also my rebuild of the lilv package on which this package depends failed due
to missing build requires on python and python-devel ]

+ No locales
+ No shared libraries
+ No bundled libraries
+ No duplicates in %files
+ Package owns directories it creates
+ File permissions are sane
+ Specfile uses macros consistently
+ Contains code
+ Documentation is small - need not be in subpackage
+ %doc not runtime essential
+ No static libraries
+ No development files
+ No subpackages
+ No libtool archives
+ Package does not own others' directories
+ Filenames valid UTF8


Summary: Only the missing build requires, otherwise OK.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]