Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: libgpod https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226022 tmz@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |alexl@xxxxxxxxxx CC| |tmz@xxxxxxxxx Flag|fedora-review? |fedora-review+ ------- Additional Comments From tmz@xxxxxxxxx 2007-02-02 14:50 EST ------- MUST items verified * rpmlint runs without errors on the srpm (just a minor warning, output below) * Adheres to naming guidelines * Specfile name matches package name * Meets packaging guidelines (except for %makeinstall usage, see below) * License meets open-source requirements * License included in %doc * License field matches the upstream license * Specfile is in American English * Specfile is legible * Source matches upstream (sha1: b2aece62a206a5b703c50e6625b173217f1d67a6) * Builds, installs, and works (tested on FC6, i386) * Owns directories that it creates * Does not own files or directories of other packages * File list has no duplicates * File perms are sane * Specfile includes %clean section * Macros used consistently * Package contains code or permissible content * Headers are in -devel subpackage * Devel package properly requires pkgconfig and the base libgpod package * Libtool archives and static archives are excluded SHOULD items verified * Builds in mock against fedora-{5,6,development}-i386-core targets * Scriplets are sane * Package functions correctly (tested on FC6) $ rpmlint libgpod-0.4.2-1.fc7.src.rpm W: libgpod setup-not-quiet This warning is very minor and easily silenced with the addition of -q to %setup. It's not a blocker as far as I know. Another very a minor point, the preferred value for the BuildRoot tag is %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) This is not a blocker. The one thing that should be fixed is to change %makeinstall to %{__make} DESTDIR=%{buildroot} install as per the packaging guidelines. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review