Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: duel3 - One on one spaceship duel in a 2D arena Alias: duel3 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226729 chris.stone@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|chris.stone@xxxxxxxxx |j.w.r.degoede@xxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From chris.stone@xxxxxxxxx 2007-02-02 13:05 EST ------- ==== REVIEW CHECKLIST ==== - rpmlint output clean - package named according to package naming guidelines - spec file name matches %{name} - package meets packaging guidelines - package licensed with open source compatible license - license tag matches actual license X license file included in %doc - spec written in American english - spec file is legible - sources match upstream 44023431a37932ab44a9cf0be9230714 Duel3_20060225_src.zip 0aa9fa786257d6f1d6dd79d2bf591070 Duel3_20060225_bin.zip - successfully compiles and builds on FC-6 x86_64 - all build dependencies listed in BR - no locales - no shared libraries - not relocatable - package owns all directories it creates X package does not bring in all Requires for dirs it does not own - no duplicates in %files - file permissions set properly - contains proper %clean section - macro usage consistent - package contains code - no large documentation - %doc does not affect runtime - no header files or static libs - no pkgconfig files - no library files with suffix - no need for devel subpackage - no libtool archives - contains proper desktop file - does not own files or directories owned by other packages ==== MUST FIX ==== - Requires icon cache package to pull in icon dir - Include artwork license in %doc -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review