Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806446 --- Comment #4 from Germán Racca <gracca@xxxxxxxxx> 2012-04-19 10:04:00 EDT --- (In reply to comment #3) > I'm going to take this review > > first look: > > - remove gcc-c++ build req > it's not necessary > > - add icon scriptlets > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache > > - install or validate the desktop file > > - did you actually test the translation? In the past we had some problems with > software from this upstream. If you want to see how it's done right have a look > at minitube (from rpmfusion) No, is this necessary? > > - remove INSTALL file from doc - users just install the package :) > > - and have a look at the remove-qtsingleapp patch in minitube. musique is > bundling the same lib too and this is not allowed. If you mean the license, it was clarified in the review of minitunes[1], otherwise I don't understand what is the point on using that patch. [1]https://bugzilla.redhat.com/show_bug.cgi?id=615554#c5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review