[Bug 806669] Review Request: janino - An embedded Java compiler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #21 from Mary Ellen Foster <mefoster@xxxxxxxxx> 2012-04-18 11:28:18 EDT ---
Created attachment 578390
  --> https://bugzilla.redhat.com/attachment.cgi?id=578390
Proposed patch

It looks good -- and simpler, so mgoldmann should be pleased. :)

The only thing I'd suggest is to put all of the jar files into a %{name}
subdirectory, because I think the Java packaging guidelines require it
(https://fedoraproject.org/wiki/Packaging:Java#Split_JAR_files)

The attached patch should do that

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]