Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812681 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> 2012-04-17 16:42:32 EDT --- This review has been produced with the help of fedora-review. Here are a few additional comments. First, the myname macro serves no useful purpose. Eliminate it, and replace all uses of %{myname} with %{name}. Second, please comment on the upstream status of the patches as described here: https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== C/C++ ==== [x]: MUST Header files in -devel subpackage, if present. [x]: MUST Package does not contain any libtool archives (.la) [x]: MUST Package does not contain kernel modules. [x]: MUST Package contains no static executables. [x]: MUST Rpath absent or only used for internal libs. [x]: MUST Package is not relocatable. ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [-]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [-]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent. rpmlint glueminisat-2.2.5-1.fc18.i686.rpm glueminisat.i686: W: spelling-error %description -l en_US boolean -> Boolean, boo lean, boo-lean glueminisat.i686: W: spelling-error %description -l en_US satisfiability -> insatiability, advisability glueminisat.i686: W: spelling-error %description -l en_US learnt -> learn, learns, learn t glueminisat.i686: W: spelling-error %description -l en_US nd -> ND, Nd, n glueminisat.i686: W: spelling-error %description -l en_US unsatisfiable -> unsatisfied, unjustifiable glueminisat.i686: W: spelling-error %description -l en_US minisat -> mini sat, mini-sat, minis at glueminisat.i686: W: no-manual-page-for-binary glueminisat 1 packages and 0 specfiles checked; 0 errors, 7 warnings. rpmlint glueminisat-2.2.5-1.fc18.src.rpm glueminisat.src: W: spelling-error %description -l en_US boolean -> Boolean, boo lean, boo-lean glueminisat.src: W: spelling-error %description -l en_US satisfiability -> insatiability, advisability glueminisat.src: W: spelling-error %description -l en_US learnt -> learn, learns, learn t glueminisat.src: W: spelling-error %description -l en_US nd -> ND, Nd, n glueminisat.src: W: spelling-error %description -l en_US unsatisfiable -> unsatisfied, unjustifiable glueminisat.src: W: spelling-error %description -l en_US minisat -> mini sat, mini-sat, minis at 1 packages and 0 specfiles checked; 0 errors, 6 warnings. rpmlint glueminisat-debuginfo-2.2.5-1.fc18.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/jamesjer/812681/glueminisat-2.2.5.tar.gz : MD5SUM this package : 1b96e19f7c0c5e0bec8c26c4eead9261 MD5SUM upstream package : 1b96e19f7c0c5e0bec8c26c4eead9261 [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [-]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [-]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise justified. [!]: SHOULD SourceX / PatchY prefixed with %{name}. Note: Source0: https://sites.google.com/a/nabelab.org/glueminisat/home/download/glueminisat-%{version}.tar.gz (glueminisat-%{version}.tar.gz) Source1: glueminisat-test.in (glueminisat-test.in) Patch0: glueminisat-FPU.patch (glueminisat- FPU.patch) Patch1: glueminisat-printf.patch (glueminisat-printf.patch) [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [x]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Rpmlint output is silent. rpmlint glueminisat-2.2.5-1.fc18.i686.rpm glueminisat.i686: W: spelling-error %description -l en_US boolean -> Boolean, boo lean, boo-lean glueminisat.i686: W: spelling-error %description -l en_US satisfiability -> insatiability, advisability glueminisat.i686: W: spelling-error %description -l en_US learnt -> learn, learns, learn t glueminisat.i686: W: spelling-error %description -l en_US nd -> ND, Nd, n glueminisat.i686: W: spelling-error %description -l en_US unsatisfiable -> unsatisfied, unjustifiable glueminisat.i686: W: spelling-error %description -l en_US minisat -> mini sat, mini-sat, minis at glueminisat.i686: W: no-manual-page-for-binary glueminisat 1 packages and 0 specfiles checked; 0 errors, 7 warnings. rpmlint glueminisat-2.2.5-1.fc18.src.rpm glueminisat.src: W: spelling-error %description -l en_US boolean -> Boolean, boo lean, boo-lean glueminisat.src: W: spelling-error %description -l en_US satisfiability -> insatiability, advisability glueminisat.src: W: spelling-error %description -l en_US learnt -> learn, learns, learn t glueminisat.src: W: spelling-error %description -l en_US nd -> ND, Nd, n glueminisat.src: W: spelling-error %description -l en_US unsatisfiable -> unsatisfied, unjustifiable glueminisat.src: W: spelling-error %description -l en_US minisat -> mini sat, mini-sat, minis at 1 packages and 0 specfiles checked; 0 errors, 6 warnings. rpmlint glueminisat-debuginfo-2.2.5-1.fc18.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint The spelling warnings are bogus. The warning about the lack of a man page is legitimate, but since the minisat2 package doesn't have one either, I can hardly start throwing stones. [!]: SHOULD SourceX / PatchY prefixed with %{name}. Note: Source0: https://sites.google.com/a/nabelab.org/glueminisat/home/download/glueminisat-%{version}.tar.gz (glueminisat-%{version}.tar.gz) Source1: glueminisat-test.in (glueminisat-test.in) Patch0: glueminisat-FPU.patch (glueminisat- FPU.patch) Patch1: glueminisat-printf.patch (glueminisat-printf.patch) This warning can be eliminated by changing the explicit "glueminisat-" prefixes to "%{name}-", for both the sources and the patches. Generated by fedora-review 0.1.3 External plugins: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review