Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812659 --- Comment #5 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2012-04-17 14:23:46 EDT --- Okay, here are my initial set of comments: * The following tags are obsolete and need to be removed: Vendor, Packager * The following tags are obsolete unless you plan on building for EPEL 5 or older: - BuildRoot * The following items are obsolete unless you plan on building for EPEL 5 or older: - "rm -rf $RPM_BUILD_ROOT" at the beginning of %install - a default %clean section that just contains "rm -rf $RPM_BUILD_ROOT" - %defattr(-,root,root,755) * I strongly advise that you always use macros like "%{buildroot}" instead of "%buildroot". While it isn't a huge deal in this relatively simple package, later, you may want to conditionalize macros (e.g. "%{?dist}"), and you will need to be using that syntax to do that cleanly. * Please use "Source0" instead of "Source". Source0 should be a full URL to the upstream provided source tarball, rpm is smart enough to parse that. (Same is true for Patch1 since upstream provides it) * In the Source0 URL, please use "%{name}" and "%{version}", so that as you update the package, that URL can remain relatively static (also prevents you from accidentally building a package with old source). * In Release, please seriously consider using "%{?dist}" at the end of the numeric field. https://fedoraproject.org/wiki/Packaging:DistTag * This code actually has a new license, instead of "Copyright only", please use: License: Par **** Clean all that up, and I'll come through and do a review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review