[Bug 756445] Review Request: tor-arm - Terminal status monitor for Tor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=756445

Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tcallawa@xxxxxxxxxx

--- Comment #6 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2012-04-16 16:38:47 EDT ---
I'm not sure why this package doesn't look like this:

%build
%{__python} setup.py build

%install
rm -rf %{buildroot}
%{__python} setup.py install --skip-build --root=%{buildroot}

(The Python packaging guidelines need an overhaul, I know, but this is the
default for noarch python packages that have setup.py.)

Are you doing this to avoid having it include its local copy of TorCtl?
Seems like it might be easier to simply add:

# This lives in pytorctl
rm -rf %{buildroot}%{_datadir}/%{realname}/TorCtl

*****

Also, there should probably be a tor-arm.desktop file which runs arm -g.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]