Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772608 --- Comment #26 from Gal Hammer <ghammer@xxxxxxxxxx> 2012-04-15 04:37:45 EDT --- (In reply to comment #24) > 1) > The BuildRoot is not necessary, Fedora figures this out automatically: Removed BuildRoot. > 2) > This looks a little suspicious. Especially in FC17+ the gdm release shouldn't > be el6? Fixed by removing support for RHEL distribution for now. > 3) > Make spec files fedora specific please otherwise the packaging is very Fixed. > 4) > /var/run is mounted dynamically as a tempfs. As a result, you will not want Fixed. It was a leftover from RHEL 6. The /var/run path is not tempfs there. > 5) > The clean section isn't needed in fedora since about 12ish or so. It can be > removed. Removed %clean section. > 6) please do not use static IDS (such as 175) in useradd. Also the proper > thing is not being done here re handling useradd failures. > See http://fedoraproject.org/wiki/Packaging:UsersAndGroups for the proper > mechanism. Fixed the user creation to match the guide lines in the link. I'm still using the static id. It is an assign id (see the setup package). > After correcting the above, I'll go through an official review Fingers crossed! :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review