Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=807017 --- Comment #13 from Richard W.M. Jones <rjones@xxxxxxxxxx> 2012-04-12 08:58:53 EDT --- Out of the rpmlint warnings, these looks suspicious: ovirt-engine.noarch: E: non-executable-script /usr/share/ovirt-engine/scripts/vds_installer.py 0644L /usr/bin/python ovirt-engine-log-collector.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/sos/plugins/postgresql.py ovirt-engine-log-collector.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/sos/plugins/jboss.py There are a lot of other warnings, but I can't see any of them being problems. eg. lots of complaints about "dangling symlinks" but they all appear to be satisfied by Required packages, so they wouldn't be a real problem (unless the dependent packages change ...) We had a discussion on IRC about the version and release fields. Currently they are: Version: %{upstream_version} Release: 10.%{upstream_release}%{?dist} The usual rule is that "version belongs to upstream and release belongs to Fedora", which would imply: Version: %{upstream_version}.%{upstream_release} Release: 10.%{?dist} I don't think this is a blocker, but it would be interesting to see what you think about making this change. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review