Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756443 --- Comment #7 from Juan Orti Alcaine <j.orti.alcaine@xxxxxxxxx> 2012-04-12 07:02:45 EDT --- Thank you for your review. I have fixed what you have told me, but I have decided to drop the patch to fix the FSF postal address, because based on other reviews I learned to not touch license information. These are the bugs reported upstream: FSF address: http://code.google.com/p/cagraph/issues/detail?id=3 PKG-INFO: http://code.google.com/p/cagraph/issues/detail?id=4 Shebangs: http://code.google.com/p/cagraph/issues/detail?id=5 SPEC file: https://raw.github.com/jorti/cagraph-fedora-package/v1.2-10.1/SPECS/python-cagraph.spec SRPM file: https://github.com/jorti/cagraph-fedora-package/raw/v1.2-10.1/SRPMS/python-cagraph-1.2-10.fc16.src.rpm Rpmlint output: SPECS/python-cagraph.spec: W: invalid-url Source0: http://cagraph.googlecode.com/files/cagraph-1.2.tar.gz HTTP Error 404: Not Found python-cagraph.noarch: E: incorrect-fsf-address /usr/share/doc/python-cagraph-1.2/examples/example99.py python-cagraph.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/cagraph/ca_graph.py python-cagraph.noarch: E: incorrect-fsf-address /usr/share/doc/python-cagraph-1.2/examples/example7.py python-cagraph.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/cagraph/axis/taxis.py python-cagraph.noarch: E: incorrect-fsf-address /usr/share/doc/python-cagraph-1.2/examples/example4.py python-cagraph.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/cagraph/axis/yaxis.py python-cagraph.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/cagraph/series/area.py python-cagraph.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/cagraph/series/dna.py python-cagraph.noarch: E: incorrect-fsf-address /usr/share/doc/python-cagraph-1.2/examples/example3.py python-cagraph.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/cagraph/series/series.py python-cagraph.noarch: E: incorrect-fsf-address /usr/share/doc/python-cagraph-1.2/examples/example8.py python-cagraph.noarch: E: incorrect-fsf-address /usr/share/doc/python-cagraph-1.2/examples/example2.py python-cagraph.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/cagraph/axis/xaxis.py python-cagraph.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/cagraph/series/line.py python-cagraph.noarch: E: incorrect-fsf-address /usr/share/doc/python-cagraph-1.2/examples/example9.py python-cagraph.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/cagraph/axis/axis.py python-cagraph.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/cagraph/series/labels.py python-cagraph.noarch: E: incorrect-fsf-address /usr/share/doc/python-cagraph-1.2/examples/example5.py python-cagraph.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/cagraph/ca_graph_file.py python-cagraph.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/cagraph/series/bar.py python-cagraph.noarch: E: incorrect-fsf-address /usr/share/doc/python-cagraph-1.2/examples/example1.py python-cagraph.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/cagraph/series/hbar.py python-cagraph.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/cagraph/ca_graph_grid.py python-cagraph.noarch: E: incorrect-fsf-address /usr/share/doc/python-cagraph-1.2/examples/test.py python-cagraph.noarch: E: incorrect-fsf-address /usr/share/doc/python-cagraph-1.2/examples/example6.py python-cagraph.src: W: invalid-url Source0: http://cagraph.googlecode.com/files/cagraph-1.2.tar.gz HTTP Error 404: Not Found 2 packages and 1 specfiles checked; 25 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review