Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810010 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tcallawa@xxxxxxxxxx --- Comment #5 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2012-04-11 16:38:38 EDT --- Just some drive-by comments: * Your BuildRoot value is invalid, please see: https://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag * The "." on its own line in each %description is unnecessary, please omit. * When doing explicit Requires, you should be doing it differently, see: https://fedoraproject.org/wiki/Packaging/Guidelines#Requires As an example, you currently have: Requires: libgenders-devel = %{version}, libgendersplusplus = %{version} This should be: Requires: libgenders-devel%{?_isa} = %{version}-%{release} Requires: libgendersplusplus%{?_isa} = %{version}-%{release} (splitting it across two lines is not required, i just did that for legibility) * You are mixing macros, specifically, "$RPM_BUILD_ROOT" and "%{buildroot}". You need to choose one and use it consistently. I strongly recommend using "%{buildroot}". * Your %defattr lines should be "%defattr(-,root,root,-)" * To filter out those provides, see: https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering * When you make changes, please increment Release and add a new entry to the %changelog, so we can see the progress over time. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review