Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811286 Alec Leamas <leamas.alec@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leamas.alec@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |leamas.alec@xxxxxxxxx --- Comment #1 from Alec Leamas <leamas.alec@xxxxxxxxx> 2012-04-11 11:28:33 EDT --- Hi! Here we go! Some *very preliminary* thoughts after just having skimmed through the spec files: - Have you missed http://fedoraproject.org/wiki/Packaging:Ruby ? In particular, the empty %prep and %build together with how the "gem install" is performed in %install? - The only difference between the two spec files is the ruby version. Such a case is better handled with something like %if 0%{?fedora} > 16 ... in a common spec file. - The long paths in the %install can be handled by doing a cd %{buildroot}%{gemdir}/gems/%{gemname}-%{version} before doing the dirty chmod/rm work, improving readability. - Likewise, you can use doc/images/*.png. - Please reorder the tags according to /etc/rpmdevtools/spectemplate-ruby.spec in rpmdevtools (e. g., move BuildArch: above the Requires:). - Try to use space in a consistent way e. g. two blank lines between main sections as %prep, %build, %install %check etc., and a single blank line as appropriate in other cases. - The Group tag is not used by Fedora, and can be skipped. If you want to have it anyway (which is perfectly sane, it's required by the RPM spec) I guess System Environment/Libraries or Development/Libraries is a better choice(?) - The empty %check can be removed Run rpmlint on all packages + spec file and submit output together with the new spec versions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review