Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771137 --- Comment #5 from Lukáš Zapletal <lzap@xxxxxxxxxx> 2012-04-11 09:05:57 EDT --- Christoph and Volker, thanks for your help here. I was waiting for Debrashi to confirm me I am free to take this package. I am now :-) All your remarks incorporated, except: - Was "vendor" used in desktop files in older versions of this package? If not, it should not be used. I did not change this, its from original version of the package. I'd rather keep it if this is not an issue. - I'm not sure about those shell scripts that act as starters. Are they really necessary? I dont follow here, you mean %{_bindir}/%{name} %{_bindir}/%{name}-remote right? They both work and I use them quite often. Please elaborate if you mean something different. - When using sed, you are hardcoding /usr/bin. Use the %{_bindir} macro instead. Do you mean hardcoding of /usb/bin/sed invocation, or hardcoding the path in the script itself? Regarding harmonizing - I think its correct, I need to do the first sed in-place, while 2nd and 3rd are used when copying the shell script to the correct place. I have also added BuildRequires: sed. I am overwriting original files, use the same links to see it. [lzap@lzapx noarch]$ rpmlint decibel-audio-player-1.08-1.fc16.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [lzap@lzapx SRPMS]$ rpmlint decibel-audio-player-1.08-1.f15.src.rpm decibel-audio-player.src:10: W: macro-in-comment %{name} decibel-audio-player.src:10: W: macro-in-comment %{version} 1 packages and 0 specfiles checked; 0 errors, 3 warnings Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review