Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=782560 --- Comment #22 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> 2012-04-06 04:10:42 EDT --- Ok, here are my comments: - Are you sure about the license? The readme file says "License: Free for any use with your own risk!". You should probably ask the author what exactly he means by that (I'm guessing public domain, but we must clarify this). - In F17 and above, the *.so files have to live under %{gem_extdir}, because they are platform dependent and %{gem_instdir} points to /usr/share/gems, which has to contain only platform independent code (also, rpmlint complains about this). - %{gem_instdir}/README* should be marked as %doc - Consider updating to the latest upstream version (2.1.3). - Please remove zero-length files, as reported by rpmlint: rubygem-ruby-shadow-doc.noarch: E: zero-length /usr/share/gems/doc/ruby-shadow-2.1.2/rdoc/created.rid rubygem-ruby-shadow-doc.noarch: E: zero-length /usr/share/gems/doc/ruby-shadow-2.1.2/ri/created.rid Please fix these issues and then the package can be approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review