Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226114 Jon Ciesla <limburgher@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |limburgher@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |limburgher@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Jon Ciesla <limburgher@xxxxxxxxx> 2012-04-05 14:39:27 EDT --- Good: ! rpmlint checks return: m2crypto.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/m2crypto-0.21.1/tests/thawte.pem This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. Fix until that would break the tests. m2crypto.x86_64: E: zero-length /usr/share/doc/m2crypto-0.21.1/demo/Zope/lib/python/Products/GuardedFile/refresh.txt Ignore or remove. ! package meets naming guidelines Should really be python-m2crypto. If you submit a rename review I'll do it. Or this could be it, really. - package meets packaging guidelines ! license ( MIT ) I see BSD-style, Apache 2.0, MIT, Zope Public License, should this not reflect all of those? - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file So just rpmlint, name and license, otherwise OK. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review