[Bug 760155] Review Request: xcb-util-image - Port of Xlib's XImage and XShmImage functions on top of libxcb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=760155

Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tcallawa@xxxxxxxxxx
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |tcallawa@xxxxxxxxxx
               Flag|                            |fedora-review+

--- Comment #2 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2012-04-05 10:57:35 EDT ---
Review
=======

- rpmlint checks return:

xcb-util-image.src: W: spelling-error Summary(en_US) libxcb -> Libby
xcb-util-image.x86_64: W: spelling-error Summary(en_US) libxcb -> Libby
4 packages and 0 specfiles checked; 0 errors, 2 warnings.

All safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (MIT) OK, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]