[Bug 809882] Review Request: ansible - Minimal SSH command and control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=809882

Michael Scherer <misc@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misc@xxxxxxxx

--- Comment #1 from Michael Scherer <misc@xxxxxxxx> 2012-04-04 12:48:19 EDT ---
Hi,

a few note :
- you should explicitely say the version of python to use in BuildRequires 
https://fedoraproject.org/wiki/Packaging:Python#BuildRequires

- the python macro are already defined on Fedora, so no need to add them again

- Prefix is forbidden

- buildRoot should not be used, except for EPEL 5
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

- so does %defattr, %clean and rm in %install 

- --record=INSTALLED_FILES is not used, and is not recommended
https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling

- it seems that %{_datadir}/ansible/ would end unowned

- I am not sure, but I think that "-n %{name}-%{version}" is uneeded, becuase
tha's the default

- the guideline ask for consistency when using macro to reference path :
%config(noreplace) /etc/ansible/hosts
%config(noreplace) %{_sysconfdir}/ansible/

- %{_mandir}/man1/*.gz
that's not mandatory, but I think that's better to not hardcode the prefix used
here, as this could be changed in the future ( ie, be something else than gz )

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]