Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809633 Emmanuel Seyman <emmanuel.seyman@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? --- Comment #3 from Emmanuel Seyman <emmanuel.seyman@xxxxxxxxxxxxxxxx> 2012-04-04 11:13:27 EDT --- (In reply to comment #2) > The Spec URL is invalid. Using spec file from SRPM. Oups. Sorry about that. > TODO: I recommend removing inc directory (bundled modules) and build-require > `perl(inc::Module::Install)' instead of `perl(ExtUtils::MakeMaker)' > (Makefile.PL:1). I've replaced the BR but removing the inc directory makes the build fail > TODO: Build-require `perl(base)' because the module can dual-live the future > (lib/HTML/TreeBuilder/LibXML.pm:6, http://search.cpan.org/~rgarcia/base/). Done > TODO: Build-require `perl(Data::Dumper)' because the module can dual-live in > the future (t/01_simple.t:5, http://search.cpan.org/~smueller/Data-Dumper/). Done > TODO: Remove useless %defattr(-,root,root,-) from %files section. Done > TODO: Remove unversioned `perl(XML::LibXML)' run-time dependency. Done. I added the perl default filter while I was at it. Spec URL: http://people.parinux.org/~seyman/fedora/perl-HTML-TreeBuilder-LibXML/perl-HTML-TreeBuilder-LibXML.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-HTML-TreeBuilder-LibXML/perl-HTML-TreeBuilder-LibXML-0.16-2.fc16.src.rpm Requesting SCM while I'm at it. New Package SCM Request ================== Package Name: perl-HTML-TreeBuilder-LibXML Short Description: HTML::TreeBuilder and XPath compatible interface with libxml Owners: eseyman Branches: f16 f17 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review