[Bug 225697] Merge Review: distcache

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225697

Jon Ciesla <limburgher@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |MODIFIED

--- Comment #6 from Jon Ciesla <limburgher@xxxxxxxxx> 2012-04-03 10:29:31 EDT ---
- rpmlint checks return:

distcache.spec:57: E: use-of-RPM_SOURCE_DIR
You use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to use
a directory for building, use $RPM_BUILD_ROOT instead.

distcache.src: W: strange-permission dc_client.init 0775L
A file that you listed to include in your package has strange permissions.
Usually, a file should have 0644 permissions.

distcache.src: W: strange-permission dc_server.init 0775L
A file that you listed to include in your package has strange permissions.
Usually, a file should have 0644 permissions.

I'm willing to fix the above if you like.

distcache.x86_64: E: incorrect-fsf-address
/usr/share/doc/distcache-1.4.5/LICENSE
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

Minor.


- package meets naming guidelines
- package meets packaging guidelines
- license ( LGPLv2 ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok - SEE ABOVE
- %clean ok
- macro use consistent - SEE ABOVE
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 

So it's really just the minor things from rpmlint, which I'll commit fixes for
unless you object, so we can close this.  Then there's the systemd migration,
but there's already a BZ open for that.  I can do that if you like.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]