Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809348 --- Comment #5 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2012-04-03 06:10:36 EDT --- rpmlint output looks good: [ankur@ankur SRPMS]$ rpmlint -i ../SPECS/darkclient.spec /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm darkclient-0.1-2.fc16.src.rpm darkclient.noarch: W: no-manual-page-for-binary darkclient Each executable in standard binary directories should have a man page. 3 packages and 1 specfiles checked; 0 errors, 1 warnings. [ankur@ankur SRPMS]$ Some nitpicks. (Not blockers): 1. python2-devel, not python-devel 2. Please use the --skip-build flag in setup.py install 3. Please replace the "darkclients" in the spec with the %{name} macro. 4. Similarly, please replace the "0.1" in the egg info with %{version} One blocker: It appears that the README file is included both in %doc and in the %{_datadir}. It's the only file in the datadir. Please remove it from the datadir, and remove datadir altogether, since it seems surplus. [ankur@ankur darkclient-0.1]$ rpm -qpl /var/lib/mock/fedora-rawhide-x86_64/result/darkclient-0.1-2.fc18.noarch.rpm /etc/darkclient.conf /usr/bin/darkclient /usr/lib/python2.7/site-packages/darkclient-0.1-py2.7.egg-info /usr/share/darkclient /usr/share/darkclient/README /usr/share/doc/darkclient-0.1 /usr/share/doc/darkclient-0.1/README [ankur@ankur darkclient-0.1]$ Minor fixes. I'll approve the package once these are fixed. The blocker is the important one, but you might as well fix the nitpicks while you're at it :) Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review