Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760153 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tcallawa@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tcallawa@xxxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2012-04-02 16:02:23 EDT --- Review ======= There are some minor cleanups you can make like: * drop rm -rf %{buildroot} from %install * drop default defattr lines * drop BuildRoot line * Use %{name}%{?_isa} instead of just %{name} in explicit Requires: * Fix the devel description (s/xcb-utilwm/xcb-util-wm). But all of those are minor. Just consider making those changes before committing. Good: - rpmlint checks return: xcb-util-wm.src: W: spelling-error Summary(en_US) libxcb -> Libby xcb-util-wm.src: W: spelling-error %description -l en_US ewmh -> whew xcb-util-wm.src: W: spelling-error %description -l en_US icccm -> ICC xcb-util-wm.x86_64: W: spelling-error Summary(en_US) libxcb -> Libby xcb-util-wm.x86_64: W: spelling-error %description -l en_US ewmh -> whew xcb-util-wm.x86_64: W: spelling-error %description -l en_US icccm -> ICC xcb-util-wm-devel.x86_64: W: spelling-error Summary(en_US) vm -> cm, v, m xcb-util-wm-devel.x86_64: W: spelling-error %description -l en_US utilwm -> utility All safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review