Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=808886 Paul Howarth <paul@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #3 from Paul Howarth <paul@xxxxxxxxxxxx> 2012-04-02 05:25:18 EDT --- perl-CPAN-Meta-Requirements-2.121-1 == rpmlint == $ rpmlint ~/perl-CPAN-Meta-Requirements-2.121-1.fc18.* 2 packages and 0 specfiles checked; 0 errors, 0 warnings. == provides == $ rpm -qp --provides ~/perl-CPAN-Meta-Requirements-2.121-1.fc18.noarch.rpm perl(CPAN::Meta::Requirements) = 2.121 perl-CPAN-Meta-Requirements = 2.121-1.fc18 == requires == $ rpm -qp --requires ~/perl-CPAN-Meta-Requirements-2.121-1.fc18.noarch.rpm perl(:MODULE_COMPAT_5.14.2) perl(Carp) perl(Scalar::Util) perl(strict) perl(version) >= 0.77 perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 == review checklist == - rpmlint OK - spec file and package naming OK - package meets packaging guidelines - license is valid for Fedora and matches upstream - upstream LICENSE file is included in package - spec file written in English and is legible - sources match upstream, as does tarball timestamp - package builds fine in mock on both i386 and x86_64 - buildreqs are complete - no locale data, libraries, devel files etc. to worry about - package is not intended to be relocatable - directory ownership is correct - no duplicate files included - permissions are sane - macro usage is consistent - package is code, not content - no large docs to consider - docs don't affect runtime - not a GUI app, no desktop file needed - filenames are all plain ASCII - CPAN::Meta 2.120921 builds successfully using this package - no scriptlets or sub-packages present nor needed - no file dependencies present - module ships with manpage == nits == - %{?perl_default_filter} isn't really needed by this package, though it does no harm either - I don't know what the use of the %{__perl} macro buys us really - There's no need to remove empty directories from the buildroot; even ancient versions of rpm like the one in Red Hat Linux 9 didn't complain about them In my local build of this package I also run the author/release tests. I appreciate that it doesn't do much to improve the test coverage of *this* package, but it does improve the test coverage of the release test packages that are used to do the testing, resulting in issues like Bug #786849 being discovered and fixed. Anyway, no blockers here. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review