Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rudeconfig - C++ library for manipulating config files https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223588 ------- Additional Comments From rc040203@xxxxxxxxxx 2007-02-01 20:37 EST ------- Packaging-wise *-3.src.rpm seems fine. There remains one (upstream) issue: /usr/include/rude/config.h uses INCLUDED_CONFIG_H as header guard. This isn't necessarily a clever choice, because INCLUDED_CONFIG_H is a pretty generic name which likely to conflict with other package's defines. I'd recommend to use _RUDE_CONFIG_H or similar. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review