[Bug 808025] Review Request: libsecret - Library for storing and retrieving passwords and other secrets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=808025

Michael Scherer <misc@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misc@xxxxxxxx
               Flag|                            |fedora-review?

--- Comment #1 from Michael Scherer <misc@xxxxxxxx> 2012-03-30 11:29:04 EDT ---
Hi,

a few comments :
- the address of the FSF is wrong in the license, you should warn upstream of
it
- you should use %global instead of %define

Otherwise, look good to start a formal review ( and a bug fix for fedora-review
who say there is multiple tag "release" found ... ).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]