Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=808336 --- Comment #3 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2012-03-30 05:17:54 EDT --- Few notes: * I don't like the name. This doesn't helps if someone searches for "gnomeDIAicons" neither for dia extensions (which traditionally named ad dia-something). I suggest you to rename it to the dia-gnomeDIAicons to better match the upstream name and to show that this is a Dia addon. * The package doesn't contain any arch-specific data so it must be marked as noarch. Please add "BuildArch: noarch" to the head of the spec-file. * It seems that you installed it to the wrong directories. When I installed your package and relaunched Dia I didn't see any new iconsets. But after I changed %install section: - %{__install} -d -m 0755 %{buildroot}%{_datadir}/%{name} - %{__cp} -av * %{buildroot}%{_datadir}/%{name} + %{__install} -d -m 0755 %{buildroot}%{_datadir}/ + %{__cp} -av * %{buildroot}%{_datadir}/ and %files section: - %{_datadir}/%{name}/* + %{_datadir}/shapes/* + %{_datadir}/sheets/* Dia finally found them. Please fix these and I'll continue. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review