Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=804666 --- Comment #3 from William Cohen <wcohen@xxxxxxxxxx> 2012-03-28 16:30:23 EDT --- Thanks for the review. I have attempted to address each of the points mentioned in the review in libpfm-4.2.0-3.fc16.src.rpm and libpfm.spec available at: http://people.redhat.com/wcohen/libpfm/ A scratch build is also available at: http://koji.fedoraproject.org/koji/taskinfo?taskID=3940897 * https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package Change requires to: Requires: %{name}%{?_isa} = %{version}-%{release} * https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries There are cases where HPC developer want static versions of the library (the compute node may not have shared libraries installed). I have split the static library into a libpfm-static sub package. * https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag Removed the unneeded Buildroot tag * https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean Removed the unneeded %clean section > %{!?with_python: %global with_python 1} You may want to look into using "%bcond_without python" instead. convered the libpfm.spec to use %bcond_without. For the file permissions it looks like the permissions were correct so removed the %defattr. > %defattr(644,root,root,755) > %doc README https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions > %attr(755,root,root) %{_libdir}/lib*.so* Ownership is root:root by default. If the mode is not 0755 for the installed lib, I highly recommend fixing it upstream and temporarily during %install. Usage of the eye-catching %attr should be limited to non-ordinary file permissions as not to overuse it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review