Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806677 --- Comment #7 from Juan Hernández <juan.hernandez@xxxxxxxxxx> 2012-03-28 06:34:23 EDT --- Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [!] Rpmlint output: Output of rpmlint of the source package: $ rpmlint jboss-web-7.0.13-3.fc18.src.rpm jboss-web.src: E: description-line-too-long C JBoss Web Server is an enterprise ready web server designed for medium and large applications, based on Tomcat. jboss-web.src: W: invalid-url URL: http://www.jboss.org/jbossweb HTTP Error 403: Forbidden jboss-web.src: W: invalid-url Source0: jboss-web-7.0.13.Final.tar.xz 1 packages and 0 specfiles checked; 1 errors, 2 warnings. Output of rpmlint of the binary packages: $ rpmlint jboss-web-7.0.13-3.fc18.noarch.rpm jboss-web-doc-7.0.13-3.fc18.noarch.rpm jboss-web-javadoc-7.0.13-3.fc18.noarch.rpm jboss-web.noarch: E: description-line-too-long C JBoss Web Server is an enterprise ready web server designed for medium and large applications, based on Tomcat. jboss-web.noarch: W: invalid-url URL: http://www.jboss.org/jbossweb HTTP Error 403: Forbidden jboss-web-doc.noarch: W: invalid-url URL: http://www.jboss.org/jbossweb HTTP Error 403: Forbidden jboss-web-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados jboss-web-javadoc.noarch: W: invalid-url URL: http://www.jboss.org/jbossweb HTTP Error 403: Forbidden 3 packages and 0 specfiles checked; 1 errors, 4 warnings. URL warnings are acceptable. The description should be shorter than 79 characters. [x] Package is named according to the Package Naming Guidelines[1]. [x] Spec file name must match the base package name, in the format %{name}.spec. [x] Package meets the Packaging Guidelines[2]. [x] Package successfully compiles and builds into binary rpms. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3939085 [x] Buildroot definition is not present [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [!] License field in the package spec file matches the actual license. The license in the spec file is "LGPLv3+" but the package contains files with a mix of licenses. Some examples: LGPLv2.1+: java/org/jboss/servlet/http/HttpEventFilterChain.java LGPLv2+: java/org/jboss/web/php/PhpThread.java ASL 2.0: java/org/apache/jasper/* LGPLv2.1+ or ASL 2.0: java/org/apache/naming/resources/ProxyDirContext.java MIT: java/org/apache/tomcat/util/json/JSONTokener.java The license type should be: LGPLv2+ and ASL 2.0 and MIT and (LGPLv2+ or ASL 2.0) [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] All independent sub-packages have license of their own [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. Checked using a recursive diff of the sources, which gives output like this: diff --recursive --unified t/jboss-web-7.0.13.Final/java/org/apache/catalina/authenticator/AuthenticatorBase.java t2/jboss-web-7.0.13.Final/java/org/apache/catalina/authenticator/AuthenticatorBase.java --- t/jboss-web-7.0.13.Final/java/org/apache/catalina/authenticator/AuthenticatorBase.java 2011-10-11 17:29:56.000000000 +0200 +++ t2/jboss-web-7.0.13.Final/java/org/apache/catalina/authenticator/AuthenticatorBase.java 2011-10-11 17:29:56.818919000 +0200 @@ -70,7 +70,7 @@ * requests. Requests of any other type will simply be passed * through. * * @author Craig R. McClanahan - * @version $Revision: 1848 $ $Date: 2011-10-11 11:29:56 -0400 (Tue, 11 Oct 2011) $ + * @version $Revision: 1848 $ $Date: 2011-10-11 17:29:56 +0200 (Tue, 11 Oct 2011) $ */ These differences are acceptable, as they appear due to distinct time zones and subversion quirks. [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [x] Package must own all directories that it creates or must require other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] File sections do not contain %defattr(-,root,root,-) unless changed with good reason [x] Permissions on files are set properly. [x] Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore) [x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing) [x] Package contains code, or permissable content. [-] Fully versioned dependency in subpackages, if present. [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [-] Package does not own files or directories owned by other packages. [x] Javadoc documentation files are generated and included in -javadoc subpackage [x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) No javadoc is generated. [x] Packages have proper BuildRequires/Requires on jpackage-utils [-] Javadoc subpackages have Require: jpackage-utils [x] Package uses %global not %define [x] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [x] If source tarball includes bundled jar/class files these need to be removed prior to building [x] All filenames in rpm packages must be valid UTF-8. [x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details) [x] If package contains pom.xml files install it (including depmaps) even when building with ant [x] pom files has correct add_maven_depmap === Maven === [x] Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms [-] If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment [-] If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why it's needed in a comment [x] Package DOES NOT use %update_maven_depmap in %post/%postun [x] Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro === Other suggestions === [x] If possible use upstream build method (maven/ant/javac) [x] Avoid having BuildRequires on exact NVR unless necessary [x] Package has BuildArch: noarch (if possible) [x] Latest version is packaged. [x] Reviewer should test that the package builds in mock. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3939085 === Issues === 1. Description line is too long, please make it shorter than 79 characters. 2. License should be "LGPLv2+ and ASL 2.0 and MIT and (LGPLv2+ or ASL 2.0)". 3. "Requires: jboss-jsp-2.1-api" should be "Requires: jboss-jsp-2.2-api". 4. The POM file doesn't include the dependencies for "jboss-*-api". === Final Notes === We are almost there! The javadoc warnings are acceptable. Once you fix the above issues I will approve. To be clear about #1, #2 and #3: --- jboss-web.spec +++ jboss-web.spec @@ -6,7 +6,7 @@ Release: 3%{?dist} Summary: JBoss Web Group: Development/Libraries -License: LGPLv3+ +License: LGPLv2+ and ASL 2.0 and MIT and (LGPLv2+ or ASL 2.0) URL: http://www.jboss.org/jbossweb # svn export # http://anonsvn.jboss.org/repos/jbossweb/tags/JBOSSWEB_7_0_13_FINAL/ # jboss-web-7.0.13.Final @@ -34,11 +34,12 @@ Requires: java Requires: jboss-annotations-1.1-api Requires: jboss-el-2.2-api -Requires: jboss-jsp-2.1-api +Requires: jboss-jsp-2.2-api Requires: jboss-servlet-3.0-api %description -JBoss Web Server is an enterprise ready web server designed for medium and large applications, based on Tomcat. +JBoss Web Server is an enterprise ready web server designed for medium and +large applications, based on Tomcat. %package doc Summary: User guide for %{name} For #4 you need to add something like this to the POM: <dependencies> <dependency> <groupId>org.jboss.spec.javax.annotation</groupId> <artifactId>jboss-annotations-api_1.1_spec</artifactId> <version>1.0.1-SNAPSHOT</version> </dependency> <dependency> <groupId>org.jboss.spec.javax.el</groupId> <artifactId>jboss-el-api_2.2_spec</artifactId> <version>1.0.1-SNAPSHOT</version> </dependency> <dependency> <groupId>org.jboss.spec.javax.servlet.jsp</groupId> <artifactId>jboss-jsp-api_2.2_spec</artifactId> <version>1.0.1.Final</version> </dependency> <dependency> <groupId>org.jboss.spec.javax.servlet</groupId> <artifactId>jboss-servlet-api_3.0_spec</artifactId> <version>1.0.1.Final</version> </dependency> </dependencies> Thanks Tony! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review