[Bug 225575] Review Request: roundcubemail - Round Cube Webmail is a browser-based multilingual IMAP client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: roundcubemail - Round Cube Webmail is a browser-based multilingual IMAP client


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225575





------- Additional Comments From limb@xxxxxxxxxxxx  2007-02-01 08:04 EST -------
Upstream's response:
--------------
2007/1/31, Jon Ciesla <limb@xxxxxxxxxxxx>:
> The parts from PEAR, namely DB, Auth, Net and Mail.  You need to let the
> end user install them on their own, since they're readily available and
> GPL-incompatible.  This won't be an issue for Fedora, as they're all
> available as Extras packages which Roundcube can require as dependencies.

OK, I'll take care of that.
>
> Also, where are the .map files in program/lib/encoding from?  How are they
> licensed?  There's a contact address in them from microsoft, which in the
> absence of concrete licensing information in the utf8.class.php file makes
> it likely that it can't be redistributed with GPL code.

The map files are from ftp://ftp.unicode.org/Public/MAPPINGS/
and the utf8.class contains the following line:
"License: Choose the more appropriated for You - I don't care."
>
> Taking care of the PEAR parts shouldn't be a problem, but the utf stuff
> probably should go and be replaced with something using this:
>
> http://us2.php.net/manual-lookup.php?pattern=utf&lang=en

utf8_encode only works from latin to utf8 but does not support other
charsets. RoundCube tries to use mbstring, iconv and
utf8_encode/decode methods and only if none of them is available or if
those do not support the requested charset the utf8.class with the
mapping files will be used.
See program/include/main.inc : rcube_charset_convert() for details about this.

If the PHP installation of the Fedora package includes mbstring you
could actually deliver RoundCube without these utf8 files.
>
> I hope this is helpful.

Thanks!
Thomas
---------------

My reply:

---------------
> OK, I'll take care of that.

Great, let me know when the new release is out.

> 
> The map files are from ftp://ftp.unicode.org/Public/MAPPINGS/
> and the utf8.class contains the following line:
> "License: Choose the more appropriated for You - I don't care."

IANAL, but it sounds fine, if a bit unwise on the copyright holder's part.

> 
> utf8_encode only works from latin to utf8 but does not support other
> charsets. RoundCube tries to use mbstring, iconv and
> utf8_encode/decode methods and only if none of them is available or if
> those do not support the requested charset the utf8.class with the
> mapping files will be used.
> See program/include/main.inc : rcube_charset_convert() for details about
> this.
> 
> If the PHP installation of the Fedora package includes mbstring you
> could actually deliver RoundCube without these utf8 files.

I'll require php-mbstring in the Fedora package, so if you ever deprecate this
and just list mbstring as a requirement (which I recommend, as it's fairly
common), it won't impact Fedora.

Eagerly awaiting the new release,
Jon

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]