Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #3 from Jeremy Newton <alexjnewt@xxxxxxxxxxx> 2012-03-27 20:08:18 EDT --- (In reply to comment #1) > I'm going to take this review and help you out. If you package gets approved > rdieter will sponsor you (I can't do that). Awesome, thanks! (In reply to comment #2) > just a quick shot: > > - your package doesnt build in mock > ->add desktop-file-utils and libtool as BuildRequires Ah, that's what I was missing, I knew I forgot something > - place your sed magic in the %install section :) As in the line that says: sed -i 's/\r//' license.txt readme.txt In the install section? seems a little odd, shouldn't this be in the prep because its the equivalent of a patch? > - please explain the optional patch. Why did you include it? Why isn't it in > upstream? Good point, I should ask upstream to include this. > (In reply to comment #0) > > >love.x86_64: W: no-manual-page-for-binary love > > > > This isn't critical, so ignored it. I can write a man page and send it upstream > > if needed. > yeah non critical, but it would be really *cool* if you can do it :) Haha yeah I'm planning to; I need to make one for a package I have in RPMFusion, so I will when I have some time to figure out how to make them. > > >love.src: W: invalid-url Source1: love-extra.tar.xz > > > > This source does not have a download link because I created it; a link above > > the source provides the source for the files I included (from Ubuntu's Debian > > files). I can provide a script > > to generate this if necessary. > is there some reason why you didn't send this to upstream? Good point, this is another thing I can send upstream. Although knowing the current development, it probably won't be incorporated until 0.8 comes out. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review