Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=807472 --- Comment #1 from Andy Grover <agrover@xxxxxxxxxx> 2012-03-27 17:41:29 EDT --- rpmlint is clean. You can make it easier by just saying %{python_sitelib} under files instead of specifying each file, it will pick up everything under there. Same goes for _libdir and _bindir and _includedir, and the * shouldn't be needed. Recommend putting a blank line between entries in the changelog Recommend using either %{buildroot} or $RPM_BUILD_ROOT, but not both. libstoragemgmt also has commandline programs, but the description only says this is a library. Should these go in a %{name}-utils pkg? At least mention them, and add manpages for them down the line. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review