Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=805666 --- Comment #3 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2012-03-27 12:48:43 EDT --- Initial comments: 1 SHOULD: drop reference to EOL'd el4 and simplify the spec by removing those extra macros 2. MUST: These look wrong to me: %define lldpd_user _lldpd %define lldpd_group _lldpd shouldn't those be the actual uid/gid to be used? 3. MUST: I don't see Source1: lldpd.service getting installed anywhere. else, all the systemd-related scriptlets will fail. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review